Mirocom/EDK2-fork
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

IntelFsp2Pkg/CacheLib: Make integer width consistent in loop condition

Browse Source 
Explicitly casts `mFixedMtrrTable[MsrNum].Length` to resolve a
`comparison-with-wider-type` CodeQL error.

https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type/

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
This commit is contained in:
Michael Kubacki
2025-04-30 11:28:32 -04:00
committed by mergify[bot]
parent 8cb24514e2
commit ee6a2bfc2c
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c
View File

@@ -328,7 +328,7 @@ ProgramFixedMtrr (
return EFI_DEVICE_ERROR;
}
for ( ; ((ByteShift < 8) && (*Len >= mFixedMtrrTable[MsrNum].Length)); ByteShift++) {
for ( ; ((ByteShift < 8) && (*Len >= (UINT64)mFixedMtrrTable[MsrNum].Length)); ByteShift++) {
OrMask |= LShiftU64 ((UINT64)MemoryCacheType, (UINT32)(ByteShift* 8));
ClearMask |= LShiftU64 ((UINT64)0xFF, (UINT32)(ByteShift * 8));
*Len -= mFixedMtrrTable[MsrNum].Length;