From ee6a2bfc2c9cfadc05ca0ecaaf17734521bb7aa0 Mon Sep 17 00:00:00 2001 From: Michael Kubacki Date: Wed, 30 Apr 2025 11:28:32 -0400 Subject: [PATCH] IntelFsp2Pkg/CacheLib: Make integer width consistent in loop condition Explicitly casts `mFixedMtrrTable[MsrNum].Length` to resolve a `comparison-with-wider-type` CodeQL error. https://codeql.github.com/codeql-query-help/cpp/cpp-comparison-with-wider-type/ Signed-off-by: Michael Kubacki --- IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c b/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c index f879c268e7..a708dcbd56 100644 --- a/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c +++ b/IntelFsp2Pkg/Library/BaseCacheLib/CacheLib.c @@ -328,7 +328,7 @@ ProgramFixedMtrr ( return EFI_DEVICE_ERROR; } - for ( ; ((ByteShift < 8) && (*Len >= mFixedMtrrTable[MsrNum].Length)); ByteShift++) { + for ( ; ((ByteShift < 8) && (*Len >= (UINT64)mFixedMtrrTable[MsrNum].Length)); ByteShift++) { OrMask |= LShiftU64 ((UINT64)MemoryCacheType, (UINT32)(ByteShift* 8)); ClearMask |= LShiftU64 ((UINT64)0xFF, (UINT32)(ByteShift * 8)); *Len -= mFixedMtrrTable[MsrNum].Length;