Mirocom/EDK2-fork
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting

Browse Source 
Move printing double newline character ('\n\n') from the beginning of
ACPI table checksum validation message to the end of the raw binary
data dump.

This way acpiview table dump looks similar regardless of whether Table
Checksum is validated or not.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
Reviewed-by: Alexei Fedorov <Alexei.Fedorov@arm.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
This commit is contained in:
Krzysztof Koch
2019-06-28 16:56:57 +08:00
committed by Ray Ni
parent 6d9603713c
commit 5a119220c1
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
View File

@@ -1,7 +1,7 @@
/** @file
ACPI parser
Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -139,7 +139,7 @@ VerifyChecksum (
((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))
);
}
Print (L"\n\nTable Checksum : OK\n\n");
Print (L"Table Checksum : OK\n\n");
} else {
IncrementErrorCount ();
if (GetColourHighlighting ()) {
@@ -149,7 +149,7 @@ VerifyChecksum (
((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))
);
}
Print (L"\n\nTable Checksum : FAILED (0x%X)\n\n", Checksum);
Print (L"Table Checksum : FAILED (0x%X)\n\n", Checksum);
}
if (GetColourHighlighting ()) {
gST->ConOut->SetAttribute (gST->ConOut, OriginalAttribute);
@@ -219,7 +219,7 @@ DumpRaw (
// Print ASCII data for the final line.
AsciiBuffer[AsciiBufferIndex] = '\0';
Print (L" %a", AsciiBuffer);
Print (L" %a\n\n", AsciiBuffer);
}
/**