From 215ed375d998b779cece5448dfaa56469b635bc3 Mon Sep 17 00:00:00 2001 From: Kun Qin Date: Thu, 24 Apr 2025 17:02:09 -0700 Subject: [PATCH] ArmPkg: ArmStandaloneMmCoreEntryPoint: Use common UUID conversion routine As new interfaces are made available to support UUID-GUID conversion, this change is made to leverage new interfaces and remove the locally duplicated code. Signed-off-by: Kun Qin --- .../ArmStandaloneMmCoreEntryPoint.c | 48 +------------------ 1 file changed, 1 insertion(+), 47 deletions(-) diff --git a/ArmPkg/Library/ArmStandaloneMmCoreEntryPoint/ArmStandaloneMmCoreEntryPoint.c b/ArmPkg/Library/ArmStandaloneMmCoreEntryPoint/ArmStandaloneMmCoreEntryPoint.c index 7b78834f7d..52194832e2 100644 --- a/ArmPkg/Library/ArmStandaloneMmCoreEntryPoint/ArmStandaloneMmCoreEntryPoint.c +++ b/ArmPkg/Library/ArmStandaloneMmCoreEntryPoint/ArmStandaloneMmCoreEntryPoint.c @@ -796,52 +796,6 @@ InitializeMiscMmCommunicateBuffer ( CopyGuid (&Buffer->HeaderGuid, ServiceGuid); } -/** - Convert UUID to EFI_GUID format. - for example, If there is EFI_GUID named - "378daedc-f06b-4446-8314-40ab933c87a3", - - EFI_GUID is saved in memory like: - dc ae 8d 37 - 6b f0 46 44 - 83 14 40 ab - 93 3c 87 a3 - - However, UUID should be saved like: - 37 8d ae dc - f0 6b 44 46 - 83 14 40 ab - 93 3c 87 a3 - - FF-A and other software components (i.e. linux-kernel) - uses below format. - - To patch mm-service properly, the passed uuid should be converted to - EFI_GUID format. - - @param [in] Uuid Uuid - @param [out] Guid EFI_GUID - -**/ -STATIC -VOID -EFIAPI -ConvertUuidToEfiGuid ( - IN UINT64 *Uuid, - OUT EFI_GUID *Guid - ) -{ - UINT32 *Data32; - UINT16 *Data16; - - Data32 = (UINT32 *)Uuid; - Data32[0] = SwapBytes32 (Data32[0]); - Data16 = (UINT16 *)&Data32[1]; - Data16[0] = SwapBytes16 (Data16[0]); - Data16[1] = SwapBytes16 (Data16[1]); - CopyGuid (Guid, (EFI_GUID *)Uuid); -} - /** A loop to delegate events from SPMC. DelegatedEventLoop() calls ArmCallSvc() to exit to SPMC. @@ -911,7 +865,7 @@ DelegatedEventLoop ( FfaMsgInfo.DirectMsgVersion = DirectMsgV2; Uuid[0] = EventCompleteSvcArgs->Arg2; Uuid[1] = EventCompleteSvcArgs->Arg3; - ConvertUuidToEfiGuid (Uuid, &ServiceGuid); + ConvertUuidToGuid ((GUID *)Uuid, &ServiceGuid); ServiceType = GetServiceType (&ServiceGuid); } else { Status = EFI_INVALID_PARAMETER;